Conversation
ddbeck
force-pushed
the
add-guideline-for-handling-a-b-tests-and-feature/xzrnqzwtxtsy
branch
from
September 11, 2026 12:15
55784c2 to
b331d26
Compare
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
reviewed
Sep 15, 2026
caugner
left a comment
Contributor
There was a problem hiding this comment.
Overall, LGTM. A few nits:
-
Could we add one or two concrete examples, as we do elsewhere, along with guidance on where to find evidence of gradual feature rollouts or removals?
-
Could we explain this in plainer terms? My understanding is that the guideline recommends using the version in which an added feature becomes available to all users, or a removed feature is no longer available to any users. Is that correct?
-
Should we acknowledge that the exact version may not always be identifiable? I believe some features are retroactively disabled in stable releases, often without public disclosure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document our approach to setting
version_addedorversion_removed, when a feature is subject to a randomized trial (A/B test, phase in, phase out, etc.).Test results and supporting details
This was inspired by the discussion Florian and I had on #30433. The guideline evolved a little when I had to to put it into our typical style.
Alternatives considered:
Related issues