0.15.1: openkal-musl 0.19.1 - #29
Merged
Merged
Conversation
0.19.1 moves its openkal-windows pin to 0.10.1, which makes a file opened for writing describable on Windows. `kal_fs_file_info` answers through NtQueryInformationFile(FileBasicInformation), which requires FILE_READ_ATTRIBUTES, and `FILE_GENERIC_WRITE` does not carry it -- so a write-only handle held every right except the one needed to ask it about itself, and `fstat` on a descriptor opened a line earlier returned EACCES. Measured on three real-Windows conformance jobs in openkal-windows: with the fix the query answers 0, without it 6. Wine answers 0 either way and is recorded there as not being a second opinion. 0.19.1 and 0.10.1 were registered, published and verified resolvable from the published index before this pin moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openkal-musl 0.19.1moves itsopenkal-windowspin to0.10.1, which makes a file opened for writing describable on Windows.kal_fs_file_infoanswers throughNtQueryInformationFile(FileBasicInformation), which requiresFILE_READ_ATTRIBUTES, andFILE_GENERIC_WRITEdoes not carry it — so a write-only handle held every right except the one needed to ask it about itself, andfstaton a descriptor opened a line earlier returnedEACCES. libarchive performs exactly that pair when opening an archive for output.Measured on three real-Windows conformance jobs in openkal-windows: with the fix the query answers
0, without it6(kal_err_access). Wine answers0either way and is recorded there as not being a second opinion.Both dependencies were registered, published and verified resolvable from the published index before this pin moved: