Skip to content

feat: show new stop page layout & features - #3491

Open
thecristen wants to merge 6 commits into
mainfrom
cbj/liveview-embedded
Open

thecristen wants to merge 6 commits into
mainfrom
cbj/liveview-embedded

Conversation

@thecristen

@thecristen thecristen commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Scope

Asana Ticket: TBA

Implementation

Using live_render/3 to embed LiveViews into a regular page

Note

This PR first fixes an issue where we couldn't use live_render/3. It turned out using different plugs for regular pages vs live view pages was making the root layout kind of confused and the security signature not matching, or something.
It's fixed by the first commit, which made the search bar break with a 403 error and necessitated the second commit:

All other POST requests seem to remain working as expected.

Kicking off the reworked Stop Page

  • Created a feature flag
  • Use the feature flag to toggle between old and new layouts

Changed in both versions: Some styling tweaks shared between both, mostly the heading sizes

Added in new layout

  • The basic side-by-side structure, with Upcoming Departures at top in the mobile breakpoint
  • Refactored the existing StopMapLive LiveView and added it to the new page where the map goes (thanks @joshlarson for the prior art in feat: Add a preview page with a stop map #2806 !)
  • Stubbed out another LiveView for the Upcoming Departures piece

Screenshots

Normal With Feature Flag
image image

How to test

Try with and without the feature flag


@thecristen
thecristen requested a review from a team as a code owner September 11, 2026 13:01
@thecristen
thecristen requested a review from jlucytan September 11, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant