feat: show new stop page layout & features - #3491
Open
thecristen wants to merge 6 commits into
Open
thecristen wants to merge 6 commits into
thecristen wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: TBA
Implementation
Using
live_render/3to embed LiveViews into a regular pageNote
This PR first fixes an issue where we couldn't use
live_render/3. It turned out using different plugs for regular pages vs live view pages was making the root layout kind of confused and the security signature not matching, or something.It's fixed by the first commit, which made the search bar break with a 403 error and necessitated the second commit:
All other POST requests seem to remain working as expected.
Kicking off the reworked Stop Page
Changed in both versions: Some styling tweaks shared between both, mostly the heading sizes
Added in new layout
StopMapLiveLiveView and added it to the new page where the map goes (thanks @joshlarson for the prior art in feat: Add a preview page with a stop map #2806 !)Screenshots
How to test
Try with and without the feature flag