Fix zero-OptFlds report metadata leaking into process values - #81
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field regression
ARSAS 1.6.31+a7e2f91 with ARIEC61850 e23b295 still showed initial StaticUrcb Event Log values such as
bits(0000, ...),bits(FFFFFFFF...), and DPC bit strings under unrelated.stValreferences. MMS validation moments later produced the correct scalar values.Root cause
MmsReportFrameMapper.TryMapOptFldsDrivenReportValuesrejected an IEC 61850 report when the mandatory OptFlds bit-string had all optional bits clear. Zero OptFlds is a valid report shape: inclusion follows immediately after RptID + OptFlds. Once rejected, the mapper could fall through to a raw AccessResult-by-index fallback, which paired report metadata (OptFlds/inclusion/reason) with DataSet members as if the metadata were process values.This exactly explains the field pattern: zero OptFlds appeared as
bits(0000, ...), the 36-member inclusion bitmap appeared as a long all-ones bit string, and later process DPC bit strings were shifted onto unrelated Boolean members.Fix
Regression coverage
Adds a field-shaped 36-member Digital DataSet report with zero OptFlds, full inclusion, mixed Boolean/DPC process values, and asserts that no report metadata leaks into projected Values. Also verifies malformed canonical frames are quarantined and reason bit 1 decodes as data-change.
No temporary patch workflow or script remains in the final branch.