Fix IEC 61850 report DataRef/value alignment - #80
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field regression
ARSAS field capture from AA1C1F13R4 showed StaticUrcb updates where a
.stValtelegram was displayed asbits(...), while later MMS verification produced the correct scalar.Root cause
For reports with
OptFlds.data-reference, IEC 61850 wire order is inclusion -> DataRef entries -> process values -> reason-for-inclusion. ARIEC61850's projection path expects its decoded item list as inclusion -> process values -> DataRef -> reason. The decoder previously preserved wire order, so DataRef-enabled reports could shift metadata/value positions.Fix
The normalization is intentionally bounded and leaves reports without DataRef unchanged.