Fix generic boolean status report projection - #79
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ARSAS event logs can receive a full CDC structure for generic SPS-style status objects, for example:
Structure(3) {stVal=false, q=Quality{...}, t=BinaryTime(...)}instead of the scalar
stValleaf. The report projector already handles known structures such asPos,Op,Str, and phase measurements, but generic Boolean status structures fall through to the raw-structure renderer.Fix
{ Boolean stVal, Quality q [, Timestamp t] }to<reference>.stVal.projected-boolean-status.{mag,q,t}are not misclassified.Regression coverage
INVERTERA2/LLN0.ACAlm1shape from the ARSAS field event log.false,good, timestamp, and projected.stValreference.REPORT_RAW_STRUCT.This is the source-of-truth engine fix; ARSAS also has a compatibility guard PR for installations still pinned to an older engine commit.