Skip to content

fix: canonicalize cross-LD SCL DataSet member references - #77

Merged
masarray merged 3 commits into
mainfrom
fix/scl-dataset-cross-ld-canonical
Aug 15, 2026
Merged

fix: canonicalize cross-LD SCL DataSet member references#77
masarray merged 3 commits into
mainfrom
fix/scl-dataset-cross-ld-canonical

Conversation

@masarray

Copy link
Copy Markdown
Owner

Problem

SCL parser keeps a human/display FCDA reference such as AA1C1F13R4/ADD/GGIO6.CBOpnd [ST], while the live model uses canonical object identity AA1C1F13R4ADD/GGIO6.CBOpnd. This prevents static DataSet members from matching cross-LDevice DataObjects in downstream signal inventory.

Fix

  • Canonicalize SCL DataSet member references at the live-model projection boundary.
  • Keep FC separately instead of appending [ST]/[MX] to the reference.
  • Preserve object-level FCD members exactly; do not invent .stVal.
  • Add regression coverage for a DataSet owned by Application/LLN0 that points to ADD/GGIO6.

This targets the real Siemens CID shape used by ARSAS Signal Selection.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 4fc3119 into main Aug 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant