wait_for_message: never advance the cursor past an unclassified message - #1
Merged
Conversation
…d is unknown A message announced over the WebSocket can be briefly unreadable; the thread lookup then failed, the message was mistaken for one on another thread, and the cursor advanced past it, so the caller lost it (observed 21 times in a row on a live deployment; both sides of a two-host conversation saw it). - rootOf retries transient lookup failures and otherwise throws instead of guessing; unknown never equals another thread - results carry `skipped` (id + reason, cursor advances) and `unclassified` (cursor held before them, note explains, call again to retry) - lookups still running when the call returns count as unclassified - after_id is the highest explicitly accounted contiguous event - two regression tests: other-thread skip followed by in-thread match; unclassified lower id holds the cursor below a valid higher id Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AoApk9grYkP1EMd4F4GVMv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01AoApk9grYkP1EMd4F4GVMv