Require an allowed TLD in fuzzy email hosts - #124
Closed
davidtaylorhq wants to merge 1 commit into
Closed
davidtaylorhq wants to merge 1 commit into
davidtaylorhq wants to merge 1 commit into
Conversation
Fuzzy links anchor on the TLD list, but since d4a73a4 the fuzzy email host accepted any final label, so `user@example.badtld` was linkified. Anchor the email host on the TLD list too, the same way `get_fuzzy_url_host_port` does. - Add a `not_links` fixture for an email with an unknown TLD. Closes markdown-it#123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fuzzy links anchor on the TLD list, but since d4a73a4 the fuzzy email host accepted any final label, so
user@example.badtldwas linkified. Anchor the email host on the TLD list too, the same wayget_fuzzy_url_host_portdoes.not_linksfixture for an email with an unknown TLD.Closes #123