Skip to content

docs: clarify custom axis labels - #137

Merged
chrispader merged 1 commit into
margelo:mainfrom
huytdps13400:fix/85-axis-label-example
Sep 17, 2026
Merged

chrispader merged 1 commit into
margelo:mainfrom
huytdps13400:fix/85-axis-label-example

Conversation

@huytdps13400

Copy link
Copy Markdown
Contributor

Summary

  • clarify that AxisLabel is app-owned rather than exported by the package
  • explain the zero-argument label callback contract and the reserved axis rows
  • replace the undefined component example with a complete React Native Text implementation that derives min/max values

Fixes #85.

Verification

Using the repository Node.js version (22.20.0) with fail-fast shell execution:

  • yarn prettier --check README.md
  • yarn test --runInBand — 2 suites, 3 tests passed
  • yarn typecheck
  • yarn lint — 0 errors; one pre-existing no-shadow warning in src/AnimatedLineGraph.tsx
  • yarn prepare
  • CI=1 yarn workspace react-native-graph-example expo export --platform web --output-dir /tmp/graph-85-web-dist
  • git diff --check

This is documentation-only; no runtime or public API behavior changes.

@chrispader chrispader left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chrispader
chrispader merged commit 82e74a1 into margelo:main Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AxisLabel example implementation

2 participants