Skip to content

Simplify the iteration logic in OscInterface #492

Description

@aalex

As developers, we want code that is easy to read, inderstand and maintain.

The logic for string tokenizing in OscInterface is quite convoluted. It would be useful to make it a lot simpler and easier to read.

It's not very clear what
QPair<QString,QString> OscInterface::next(const QString& path) does. It splits a string into token. Instead, but one by one. Instead, we could very well write a static function that returns list of tokens. (instead of an iterator) Also, it doesn't need to be a member of that class. I think the code also needs more comments.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions