RTFDB-4842: Improve user input handling in "mapbox-gl-geocoder" - #556
Open
pahuta wants to merge 2 commits into
Open
Conversation
- Add `options.inputTransforms.trimCoordinatesPunctuation` option (default `false`) - Extract whitespace trimming into a new private `_transformInput()` method, called recursively until a pass leaves the input unchanged - When enabled, trim leading/trailing punctuation characters from input that looks like coordinates, using a new relaxed `utils.RELAXED_COORD_RGX` - Move default options into a module-level `defaultOptions` object instead of `MapboxGeocoder.prototype.options`, and initialize `_headers` in the constructor - Add tests covering the new option's default value, enabled/disabled behavior, recursive trimming, and non-coordinate input https://mapbox.atlassian.net/browse/RTFDB-4842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
options.inputTransforms.trimCoordinatesPunctuationoption (defaultfalse)_transformInput()method, called recursively until a pass leaves the input unchangedutils.RELAXED_COORD_RGXdefaultOptionsobject instead ofMapboxGeocoder.prototype.options, and initialize_headersin the constructorhttps://mapbox.atlassian.net/browse/RTFDB-4842
npm run docsand commit changes to API.mdmainheading before mergingPrevious and still a default behaviour vs new behavior with new config:
semi.mp4