RTFDB-4842: Improve user input handling in "mapbox-gl-geocoder" - #555
Open
pahuta wants to merge 2 commits into
Open
RTFDB-4842: Improve user input handling in "mapbox-gl-geocoder"#555pahuta wants to merge 2 commits into
pahuta wants to merge 2 commits into
Conversation
- Trim user input once, at the top of `_geocode()`, so it applies consistently to both forward and reverse geocoding - Remove now-redundant `.trim()` call in the forward-geocoding branch of `_setupConfig()` - Simplify `REVERSE_GEOCODE_COORD_RGX` by dropping the leading/trailing whitespace handling, since input reaching it is now always pre-trimmed - Add tests covering reverse-geocode coordinate strings with leading/trailing whitespace and whitespace around the comma, and forward-geocode queries with surrounding whitespace https://mapbox.atlassian.net/browse/RTFDB-4842
underoot
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_geocode(), so it applies consistently to both forward and reverse geocoding.trim()call in the forward-geocoding branch of_setupConfig()REVERSE_GEOCODE_COORD_RGXby dropping the leading/trailing whitespace handling, since input reaching it is now always pre-trimmedhttps://mapbox.atlassian.net/browse/RTFDB-4842
npm run docsand commit changes to API.mdmainheading before merging