Add support for button.pressed_for(ms) - #21
Open
madleech wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long requested (see #8) is support for determining how long the button has been pressed for. When writting some child-proof code recently I ran into this limitation and realised how useful this feature would be.
This adds
button.pressed_for(ms)andbutton.held_for(). The two are basically identical, just different ways of calling it.if (button.pressed_for(1000))would be the normal interface, but if you want to calculate the number of repeats you can usebutton.held_time() % 1000and get the repeat count, which can also be useful.Note: includes a slight rejiggle of the variable ordering to save a few bytes on 32 bit platforms.