refactor: reduce filteredMparticleUser cognitive complexity for Sonar - #1336
Merged
jaissica12 merged 9 commits intoAug 24, 2026
Conversation
PR SummaryLow Risk Overview Kit blocking and forwarder attribute/identity filters still run in the same order. Array attributes continue to be copied so kits cannot mutate store values. Adds Jest coverage for missing store data, kit-blocked keys/identities, factory vs method-argument filters, and identity-type-to-name mapping. Reviewed by Cursor Bugbot for commit 64bda99. Bugbot is set up for automated code reviews on this repo. Configure here. |
rmi22186
approved these changes
Aug 19, 2026
4 tasks
jaissica12
force-pushed
the
refactor/SDKE-1193-filteredMparticleUser-cognitive-complexity
branch
2 times, most recently
from
August 21, 2026 17:28
902aa71 to
45900ca
Compare
alexs-mparticle
approved these changes
Aug 21, 2026
jaissica12
force-pushed
the
refactor/SDKE-1193-filteredMparticleUser-cognitive-complexity
branch
from
August 21, 2026 18:17
8716d89 to
53eeece
Compare
jaissica12
force-pushed
the
refactor/SDKE-1193-filteredMparticleUser-cognitive-complexity
branch
from
August 24, 2026 13:29
53eeece to
824c5df
Compare
Match Sonar and keep the same allow-when-missing-blocker behavior for attributes and identities.
Add Jest coverage for MPID, attribute/list copies, kit blocking, and identity mapping so the filtered user object is not only hit via forwarder integration tests.
Match existing Jest it() naming in this repo.
…ters Drop the overlapping identity mapping test, split kit-block vs omit-blocker, and assert factory-then-method list filters plus Rokt-style missing userIdentityFilters.
jaissica12
force-pushed
the
refactor/SDKE-1193-filteredMparticleUser-cognitive-complexity
branch
from
August 24, 2026 14:54
824c5df to
346350a
Compare
crisryantan
reviewed
Aug 24, 2026
Co-authored-by: Cris Ryan Tan <crisryantan@gmail.com>
crisryantan
reviewed
Aug 24, 2026
crisryantan
reviewed
Aug 24, 2026
crisryantan
approved these changes
Aug 24, 2026
Co-authored-by: Cris Ryan Tan <crisryantan@gmail.com>
fix types Co-authored-by: Cris Ryan Tan <crisryantan@gmail.com>
Optional kitBlocker? before required key fails TS1016. Match isIdentityAllowed: KitBlocker | undefined, same runtime.
|
jaissica12
added a commit
that referenced
this pull request
Aug 24, 2026
…#1336) * refactor: reduce filteredMparticleUser cognitive complexity for Sonar * refactor: use optional chaining for kit blocker allow checks Match Sonar and keep the same allow-when-missing-blocker behavior for attributes and identities. * test: unit-cover filteredMparticleUser kit and forwarder filtering Add Jest coverage for MPID, attribute/list copies, kit blocking, and identity mapping so the filtered user object is not only hit via forwarder integration tests. * test: prefix filteredMparticleUser cases with should Match existing Jest it() naming in this repo. * test: dedupe filteredMparticleUser cases and cover dual forwarder filters Drop the overlapping identity mapping test, split kit-block vs omit-blocker, and assert factory-then-method list filters plus Rokt-style missing userIdentityFilters. * Apply suggestion from @crisryantan Co-authored-by: Cris Ryan Tan <crisryantan@gmail.com> * Apply suggestion from @crisryantan Co-authored-by: Cris Ryan Tan <crisryantan@gmail.com> * Apply suggestion from @crisryantan fix types Co-authored-by: Cris Ryan Tan <crisryantan@gmail.com> * fix: type kitBlocker as possibly undefined before required key Optional kitBlocker? before required key fails TS1016. Match isIdentityAllowed: KitBlocker | undefined, same runtime. --------- Co-authored-by: Cris Ryan Tan <crisryantan@gmail.com>
Collaborator
|
🎉 This PR is included in version 2.79.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
filteredMparticleUserJS → TS migration PR.What Has Changed
isAttributeKeyAllowed,buildUserAttributesCopy,buildFilteredUserIdentities, etc.)continue/ helper extraction to satisfy Sonar cognitive complexity limitsScreenshots/Video
Checklist
Additional Notes
refactor/SDKE-1193-migrate-filteredMparticleUser-to-TS(migration-only).development(or merge the stack in order).Reference Issue (For employees only. Ignore if you are an outside contributor)