chore(french): novhell drop Accept-Encoding override - #2496
Closed
Balrog57 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing: could not reproduce on emulator (app v2.1.0 + plugin v1.0.4 shows 393 chapters on test network). Keeping this as an unproven cleanup would be noise; will reopen with evidence if the root cause is identified. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Context
Reported symptom: opening a Novhell novel in the app shows no chapters, while the WebView renders fine. I investigated but could not reproduce it:
ode scripts/live-check-plugin.js-equivalent harness: all PASS (5 novels, 393 chapters, chapter body 15805 chars); all 5 novels parse (244-452 chapters) and sampled first/middle/last chapters return 11k-28k chars.
So this PR does not claim to fix that report - the cause is still unknown (possibly IP-based bot challenge on the reporter's network, or a stale installed plugin).
What this PR does
Removes the anomalous \Accept-Encoding: deflate\ override from \getCheerio\ so the app default headers (\gzip, deflate\ + Android User-Agent, see \src/plugins/helpers/fetch.ts) apply - the same as every other non-French plugin in the repo. A manually-set \Accept-Encoding\ disables transparent response decompression on Android (OkHttp), so the override is a latent 0-chapter risk with zero benefit.
Tests