Skip to content

chore(french): novhell drop Accept-Encoding override - #2496

Closed
Balrog57 wants to merge 1 commit into
lnreader:masterfrom
Balrog57:fix-novhell-chapters-empty
Closed

chore(french): novhell drop Accept-Encoding override#2496
Balrog57 wants to merge 1 commit into
lnreader:masterfrom
Balrog57:fix-novhell-chapters-empty

Conversation

@Balrog57

@Balrog57 Balrog57 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Update version code if an existing plugin was modified (1.0.4 -> 1.0.5)
  • Test changes in Plugin Playground or the app (live-check + on-device below)
  • Commit messages follow type(scope): description

Context

Reported symptom: opening a Novhell novel in the app shows no chapters, while the WebView renders fine. I investigated but could not reproduce it:

  • Emulator + app v2.1.0 + plugin v1.0.4 (official code): Tempest of the Stellar War opens with 393 chapters.

  • ode scripts/live-check-plugin.js-equivalent harness: all PASS (5 novels, 393 chapters, chapter body 15805 chars); all 5 novels parse (244-452 chapters) and sampled first/middle/last chapters return 11k-28k chars.
  • Cloudflare answers plain HTML (identity) to \Accept-Encoding: deflate\ even with the exact app headers over HTTP/1.1 and HTTP/2, so the override is harmless on the tested path.

So this PR does not claim to fix that report - the cause is still unknown (possibly IP-based bot challenge on the reporter's network, or a stale installed plugin).

What this PR does

Removes the anomalous \Accept-Encoding: deflate\ override from \getCheerio\ so the app default headers (\gzip, deflate\ + Android User-Agent, see \src/plugins/helpers/fetch.ts) apply - the same as every other non-French plugin in the repo. A manually-set \Accept-Encoding\ disables transparent response decompression on Android (OkHttp), so the override is a latent 0-chapter risk with zero benefit.

Tests

  • Live-check harness with the default-header path: all PASS (popular 5, search 1, parseNovel 393 chapters, parseChapter 15805 chars).
  • On-device (emulator, app v2.1.0): updated installed plugin 1.0.4 -> 1.0.5 via local repository manifest, reopened the novel - still 393 chapters, no regression.
  • \ sc\ (ES5 production config) and eslint pass.

@Balrog57 Balrog57 changed the title fix(french): novhell shows no chapters in app chore(french): novhell drop Accept-Encoding override Sep 3, 2026
@Balrog57

Balrog57 commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Closing: could not reproduce on emulator (app v2.1.0 + plugin v1.0.4 shows 393 chapters on test network). Keeping this as an unproven cleanup would be noise; will reopen with evidence if the root cause is identified.

@Balrog57 Balrog57 closed this Sep 3, 2026
@Balrog57
Balrog57 deleted the fix-novhell-chapters-empty branch September 3, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant