fix: handle RoomIO microphone track replacement - #6744
Merged
chenghao-mou merged 11 commits intoAug 28, 2026
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
chenghao-mou
marked this pull request as draft
August 10, 2026 17:56
chenghao-mou
changed the title
- Recreate RTC audio streams when tracks remain subscribed after EOS - Prevent reattachment after unsubscribe or input close
chenghao-mou
force-pushed
the
chenghao/fix/AGT-3239-reattach-roomio-audio-input
branch
from
August 12, 2026 14:23
7d3c213 to
659920f
Compare
chenghao-mou
marked this pull request as ready for review
August 12, 2026 14:54
davidzhao
approved these changes
Aug 24, 2026
Track switches can overlap close and pre-connect fetches. Track all forward tasks, retry incomplete fetches, and keep detached inputs silent.
samvallad33
added a commit
to samvallad33/agents
that referenced
this pull request
Aug 27, 2026
Track identity on publication SID is already handled there. Keep the STT/VAD pump and handoff recovery for the session freeze. Co-authored-by: Cursor <cursoragent@cursor.com>
samvallad33
added a commit
to samvallad33/agents
that referenced
this pull request
Aug 27, 2026
Track identity on publication SID is already handled there. Keep the STT/VAD pump and handoff recovery for the session freeze. Co-authored-by: Cursor <cursoragent@cursor.com>
samvallad33
added a commit
to samvallad33/agents
that referenced
this pull request
Aug 27, 2026
Track identity on publication SID is already handled there. Keep the STT/VAD pump and handoff recovery for the session freeze.
A track replacement could restart the pre-connect wait after its configured timeout and delay live audio. Treat timeout and read failures as consumed while keeping cancellation retryable.
chenghao-mou
deleted the
chenghao/fix/AGT-3239-reattach-roomio-audio-input
branch
August 28, 2026 12:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RoomIO treated the publication SID as track identity, so a replacement concrete track under the same publication was ignored. It also did not observe
track_unsubscribed.Track concrete identity and make the SDK unsubscribe and subscribe events authoritative. This avoids speculative stream recovery and follows the RTC lifecycle.
Addresses AGT-3239