places-sidebar: Add touch screen support for eject button - #3823
Open
sulincix wants to merge 1 commit into
Open
Conversation
Allow the eject/unmount action on the places sidebar to be triggered via touch events (`GDK_TOUCH_END`). We safely check the event type first before evaluating `event->button` to prevent reading undefined fields during a touch event. Fixes touch screen usability where tapping the eject icon previously had no effect.
Member
|
Hi did you test this on hardware? This function only runs on a 'button-release-event' signal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the eject/unmount action on the places sidebar to be triggered via touch events (
GDK_TOUCH_END).We safely check the event type first before evaluating
event->buttonto prevent reading undefined fields during a touch event.Fixes touch screen usability where tapping the eject icon previously had no effect.