VLC backend as an additional optional Playback backend - #424
Open
fridrich wants to merge 30 commits into
Open
Conversation
Author
|
With the changes to make the mpv backend optional, eventually one can decide to remove completely the in-tree mpv.py file and use the system-wide installed python mpv bindings. One can also decide that either of the two backends will be enough for the application to start. On my system using the nouveau driver, mpv is rather useless, but vlc is working really nice. So, for me, having only vlc backend is just fine. For others, it might be different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some video drivers, like for instance nouveau, the MPV backend is disastrous and produces a lot of artifacts. Whereas vlc/libvlc renders the videos just fine.
The only caveat is that libvlc does not have any way to be controlled if it is not by programming the interface oneself. So, I stitched together a simple interface with play/pause button, stop button and a menu/sandwich button allowing us to list and change Audio/Video/Subtitle streams.
The playback_bar has a pause button that is rendered as pause even though the playback is paused. So I just implemented a simple button toggling extracted it and reused in the VLC backend too.