style: refine dock app item sizing and pressed state - #1718
Open
wjyrich wants to merge 1 commit into
Open
Conversation
1. Fix AppItem Control sizing to properly align with hover background 2. Use explicit width/height properties instead of anchors.fill 3. Center AppItem within parent for consistent positioning 4. Adjust icon container left margin based on hover background spacing in title active state 5. Add pressed state visual feedback with semi-transparent white background Log: Refined dock app item layout and added pressed state visual effect Influence: 1. Verify dock app items display correctly in both title and icon-only modes 2. Test icon alignment with hover background spacing 3. Verify pressed state visual feedback appears when clicking app items 4. Test app item sizing across different dock positions and orientations 5. Verify drag and drop functionality remains unaffected style: 优化 Dock 应用项目尺寸和按压状态 1. 修复 AppItem Control 尺寸以正确对齐悬停背景 2. 使用显式的宽高属性替代 anchors.fill 3. 将 AppItem 居中于父级,保持定位一致 4. 根据悬停背景间距调整标题激活状态下的图标容器左边距 5. 添加按压状态的视觉反馈,使用半透明白色背景 Log: 优化 Dock 应用项目布局并添加按压状态视觉效果 Influence: 1. 验证 Dock 应用项目在标题模式和图标模式下均正常显示 2. 测试图标与悬停背景间距的对齐效果 3. 验证点击应用项目时按压状态的视觉反馈 4. 测试应用项目在不同 Dock 位置和方向下的尺寸表现 5. 验证拖拽功能不受影响 PMS: BUG-375517 BUG-375531
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefines dock app item sizing, centering, and title-mode icon spacing to match hover backgrounds, and adds semi-transparent pressed-state feedback while keeping existing hover and drag behavior paths intact. State diagram for dock app item background feedbackstateDiagram-v2
[*] --> normal
normal --> hovered : pointer hover
hovered --> pressed : pointer press
pressed --> hovered : pointer release
hovered --> normal : pointer exit
normal --> pressed : pointer press
pressed --> normal : pointer release outside
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: [] 2. 代码质量 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: ['建议在 width/height 属性上方添加简短注释,说明水平/垂直布局下的尺寸策略'] 3. 代码性能 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: [] 4. 代码安全 🔒评价: 优秀 ✅ 通过
安全漏洞详情: 建议: [] 💡 改进建议代码示例本报告由 AI 代码审查工具自动生成 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log: Refined dock app item layout and added pressed state visual effect
Influence:
style: 优化 Dock 应用项目尺寸和按压状态
Log: 优化 Dock 应用项目布局并添加按压状态视觉效果
Influence:
PMS: BUG-375517 BUG-375531
Summary by Sourcery
Refine dock app item layout and interaction feedback for consistent alignment and clearer pressed states.
Bug Fixes:
Enhancements: