Propagate exclude credential - #213
Open
iinuwa wants to merge 6 commits into
Open
Conversation
Previously, the credential service would only return successful responses; when an authenticator errored, the UI would update with an error response, and then the user would have to close the window to finish cancelling the request, and the cancellation would map to NotAllowedError. But if we want to return other errors, like InvalidStateError when credentials are excluded, we have to return the response from the authenticator. This isn't perfect; we need to have two levels of errors: per-authenticator errors and ceremony errors. If an authenticator returns a non-terminal per-authenticator error, (e.g. not CredentialExcluded), we should signal that to the UI, but restart the transport. If a ceremony success or error occurs, then we should return the error.
This lines up with what USB and NFC do, and cleans up HybridStateStream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211.
This is going to conflict with #204 though, so I'll wait until that lands to merge this.