fix: converge status tags across lifecycle churn - #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- Replace sampled status counts with a coalescing atomic metric mask marked at Request, pending-Request, Session, active-Session, and error lifecycle transitions.\n- Preserve the accepted-WebSocket invalidation before ConnectFn and converge selected tags when between-pass churn returns a count to its prior value.\n- Centralize dirty-tag and Session registry bookkeeping; keep private state grouped and public documentation concise and current.\n- Add faithful HTTP/WebSocket regressions for issue 380 and the related Session-count ABA path.\n\n## Testing\n\n- go generate ./...\n- go vet ./...\n- gofmt -l .\n- gofumpt -l on changed Go files\n- staticcheck ./...\n- golangci-lint run\n- gosec ./...\n- go build ./...\n- JAWS_REQUIRE_NODE=1 go test -race -coverprofile=/private/tmp/jaws-coverage.out ./...\n- JAWS_REQUIRE_NODE=1 go test ./...\n- focused lifecycle and testing/synctest tests: 10 race-enabled runs\n\nFixes #380