Set no-store during request creation - #375
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Page metadata carries a one-use Request key. Replaying a cached response reuses the consumed key, so the page cannot establish another WebSocket connection.
Jaws.NewRequestaccept the page response writer and replaceCache-Controlwithno-storebefore request construction or renderingui.Handler,jawstest, examples, tests, benchmarks, and the request exercise scriptHeadHTMLdoes not modify response headersHeadHTMLand verifies the committed response still contains exactly oneno-storedirectiveCompatibility
This is a source-breaking API change:
Callers must pass the response writer used for the page and call
NewRequestbefore writing response headers or body.NewRequestreplaces any existingCache-Controlvalue; calling it after the response is committed cannot change the sent headers.Verification
JAWS_REQUIRE_NODE=1 go test -race ./...JAWS_REQUIRE_NODE=1 go test ./...go vet ./...go build ./...staticcheck ./...golangci-lint rungosec ./...gofumpt -l .git diff --check