LCORE-2547: rename llama_stack config key to ogx with deprecated alias - #2560
Open
asimurka wants to merge 1 commit into
Open
LCORE-2547: rename llama_stack config key to ogx with deprecated alias#2560asimurka wants to merge 1 commit into
asimurka wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedToo many files! This PR contains 119 files, which is 19 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (119)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
asimurka
force-pushed
the
rename-llama-stack-config-key-to-ogx
branch
from
August 27, 2026 13:07
16f9231 to
43effb8
Compare
asimurka
force-pushed
the
rename-llama-stack-config-key-to-ogx
branch
from
August 27, 2026 13:15
43effb8 to
784c5f8
Compare
Contributor
Author
|
E2E test fails are expected due to a change in workflow. See CI on fork here: https://github.com/asimurka/lightspeed-stack/actions/runs/33075918947/job/98533239026 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename the root Lightspeed Core Stack configuration YAML key from
llama_stack:toogx:.Configuration.ogxreplacesConfiguration.llama_stackin the Pydantic model and runtime accessors.llama_stack:still load (ogxtakes precedence; otherwisellama_stackis mapped toogxwith a deprecation warning).ogx.url,config,library_client_config_path, etc.) are unchanged.Type of change
pyproject.toml+uv.lock]requirements.*.txtfor Konflux]Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Unit tests
uv run pytest tests/unit/models/config/test_llama_stack_configuration.py uv run pytest tests/unit/test_configuration.py -k "native_override or llama_stack" uv run pytest tests/unit/telemetry/test_configuration_snapshot.py uv run make test-unitIntegration tests
Linting
Note:
uv run make verifystill fails on pre-existing mypy errors in unrelated files (test_otel_tracing.py,test_a2a.py,test_conversations*.py).Manual verification
ogx:— service starts normally.llama_stack:only — loads with deprecation warning;ogxsection is populated.ogxis used.