Migrate from nette/tester to PHPUnit - #37
Merged
Merged
Conversation
- Replace nette/tester with phpunit/phpunit ^13.3. - Convert XmlLoaderTest.phpt to a standard PHPUnit test. - Add phpunit.xml.dist with cache in cache/phpunit. - The test file now passes phpcs and phpstan checks.
- Enable failOnAllIssues and all beStrictAbout options. - Require coverage metadata; add CoversClass attributes to the test. - Rewrite the check composer script as an array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/XmlLoaderTest.phptto a standard PHPUnit test intests/XmlLoaderTest.php.phpunit.xml.distwith strict settings:failOnAllIssuesand allbeStrictAbout*options. The cache goes tocache/phpunit, which git already ignores.checkcomposer script to runphpunitand rewrite it as an array.Notes
expectExceptionMessageMatcheswith a regex. This replaces the tester wildcards, because the libxml message differs across versions..phptto.phpputs the test file under phpcs and phpstan for the first time. The file now follows the coding standard and passes phpstan on level max with strict rules.