Skip to content

Sync weighted comparison operators - #367

Closed
jswent wants to merge 2 commits into
libsemigroups:mainfrom
jswent:weighted-ops
Closed

Sync weighted comparison operators#367
jswent wants to merge 2 commits into
libsemigroups:mainfrom
jswent:weighted-ops

Conversation

@jswent

@jswent jswent commented Dec 1, 2025

Copy link
Copy Markdown
Member

No description provided.

@jswent
jswent marked this pull request as draft December 1, 2025 22:32
@jswent

jswent commented Dec 1, 2025

Copy link
Copy Markdown
Member Author

@james-d-mitchell just wanted to put this in here to get your thoughts: how do you want to deal with weight input checking for python bindings? I just added the wt_shortlex_compare which does the checks.

@jswent jswent changed the title order: add wt_shortlex_compare from libsemigroups Sync weighted comparison operators Dec 1, 2025
@jswent
jswent marked this pull request as ready for review December 3, 2025 14:36
@jswent
jswent marked this pull request as draft December 3, 2025 14:37
@jswent

jswent commented Dec 3, 2025

Copy link
Copy Markdown
Member Author

will do a bit more testing on this before getting reviewed, had some fiddly behaviour with str

@james-d-mitchell james-d-mitchell added the libsemigroups-feature-not-yet-supported Label for issues and PRs related to features of libsemigroups not yet supported here label Feb 24, 2026
@james-d-mitchell

Copy link
Copy Markdown
Member

Superseded by #472, thanks @jswent !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libsemigroups-feature-not-yet-supported Label for issues and PRs related to features of libsemigroups not yet supported here

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants