feat: Add basic hole punching support for py-libp2p - #922
Closed
asmit27rai wants to merge 10 commits into
Closed
asmit27rai wants to merge 10 commits into
asmit27rai wants to merge 10 commits into
Conversation
- Implement DCUtR protocol for hole punching coordination - Add basic example demonstrating hole punching - Include initial test suite - Add documentation
Member
|
@asmit27rai : Hi Asmit. Hole punching is already there and well merged: #668 Your task was interop between py-libp2p and go-libp2p in reference to hole punching and not adding support for hole punching. Please catch up with @acul71 (Luca) and @Winter-Soren (Soham) on this front. Appreciate it. |
- Implement DCUtR (Direct Connection Upgrade through Relay) protocol - Add hole punching examples and comprehensive tests - Update imports to use existing dcutr_pb2 instead of duplicate protobuf - Fix asyncio/trio compatibility issues in examples and tests - Enable full parallel test execution (762 tests) - Remove duplicate protobuf definitions to prevent symbol conflicts All tests pass and hole punching functionality is fully integrated.
Collaborator
|
@asmit27rai |
Contributor
Author
Reviewed and Merged. |
Collaborator
|
Hello @asmit27rai , please remind me is this only a initial pr for the issue ? |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #733