Support vendoring - #10
Conversation
6dd17aa to
220dbc6
Compare
0fae979 to
f5d0918
Compare
|
Also, updated libcdio to |
MonterraByte
left a comment
There was a problem hiding this comment.
Just a few minor things left.
The native library version is reflected in the semver metadata of the crate's version. Declare this as a minimum version when probing the system for the native library.
libcdio uses a custom `unistd.h` for MSVC builds. Update the Rust build script accordingly.
|
Thanks! By the way, would you be interested in moving this repo into the |
Sure! |
You've been invited to the libcdio org and may move the repository. |
|
Repo has been moved. It would probably be a good idea to share access to the crates.io package. Which account(s) should I add to the owners list? |
|
You may add me and rocky, the author of libcdio. |
|
I've added you. Couldn't add Rocky since they haven't linked their GitHub account to crates.io. |
|
@MonterraByte, would you mind renaming this repository to something that indicates this is for Rust? For example, rust-libcdio-sys (or libcdio-sys-rust, or something). I've had this discussion with @skr4n, and I realize that in the Rust community and in Rust crates, I will probably rename the libcdio C library GitHub repository to Also, this probably would be best brought up as a discussion rather than here. But discussions haven't been set up and I didn't want to add that without checking with you first. See:
|
I have now linked my account to GitHub. Thanks. |

vendoredalong with an opt-out env variableLIBCDIO_NO_VENDOR.v3.0.0+2.3.0p2.0.0Closes #8