Add pinned Interrogate docstring coverage gate (#676) - #680
Draft
leynos wants to merge 1 commit into
Draft
Conversation
Pin Interrogate 1.7.0 in the Makefile and run it against the repository-owned Python infrastructure at 100% documented coverage. Preserve the estate-synchronised spelling helper exemption while documenting every remaining missing constructor and nested helper. Protect the pin and lint integration with workflow contract coverage.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueWarning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Comment |
Contributor
Reviewer's GuideIntroduces a pinned Interrogate 1.7.0 quality gate requiring 100% docstring coverage for repository-owned Python sources, with explicit spelling-helper exclusions, documentation, workflow contract enforcement, and the missing docstrings needed to pass the gate. Flow diagram for the Interrogate Python lint gateflowchart LR
Sources[PYTHON_SOURCES] --> Exclusions[INTERROGATE_EXCLUDES]
Exclusions --> Interrogate[interrogate==1.7.0]
Interrogate --> Coverage{100% coverage?}
Coverage -->|pass| LintPython[make lint-python passes]
Coverage -->|fail| LintPythonFail[make lint-python fails]
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds a pinned
interrogate==1.7.0gate for NetsukePython infrastructure, so
make lint-pythonnow requires 100%docstring coverage across the repository-owned source boundary.
Closes #676.
Review walkthrough
lint-pythonintegration.typ.overloadexception policy.Validation
make check-fmt: passedmake lint: passed; Interrogate reports 100%make doc-coverage: passed (99.14%)make test: passed (2,798 nextest tests and doctests)make test-workflow-contracts: passed (276 tests)make markdownlint: passedmake nixie: passedcoderabbit review --agent: invoked twice after deterministic gates; the service did not return or store review findings.Notes
97.7%(544/557definitions; 13 missing). The issue-comment API rejected recording it withResource not accessible by integration; the scoped gate now passes at 100%.References
https://lody.ai/leynos/sessions/6322cc30-e75e-4b9f-b609-ccde83f647ef