fix: honor reference image resize opt-out in server requests - #2011
Merged
Merged
Conversation
Owner
|
Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto_resize_ref_image: falsepreserve native dimensions for nativeref_imagesand SDAPIextra_images.auto_resize_ref_imageis enabled or omitted.init_image/img2img semantics.Related Issue / Discussion
Related to #2004.
The server previously resized base64 reference images to the requested output size during decode. This occurred before the later
resize_before_vaeoption was evaluated, so settingauto_resize_ref_image: falsecould not restore the original pixels. For PiD, which bypasses the later reference-VAE resize path, the prematurely upscaled reference was encoded directly.This intentionally takes the compatibility-preserving approach: the existing opt-out now works, while default server requests retain their current behavior. It differs from #2007, which proposes preserving native reference dimensions by default.
Verification
auto_resize_ref_image: false: reference remains 1x1 through the generation request.cmake --build build_issue2004 --target sd-server -j 4withSD_METAL=ON.git diff --check.Full PiD image-quality verification was not run because the required PiD model weights are not available locally.