Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ djangorestframework==3.15.1
# via -r requirements.in
exceptiongroup==1.3.1
# via celery
google-api-core[grpc]==2.30.0
google-api-core==2.30.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Annotation-only — the [grpc] extras markers dropped here and on googleapis-common-protos don't change the install set. grpcio==1.78.0 and grpcio-status==1.62.3 remain their own pinned lines, so uv pip sync installs the same packages. Noting it so it isn't read as grpc support being dropped.

# via
# google-cloud-appengine-logging
# google-cloud-core
Expand All @@ -111,7 +111,9 @@ google-auth==2.48.0
# google-api-core
# google-cloud-appengine-logging
# google-cloud-core
# google-cloud-error-reporting
# google-cloud-kms
# google-cloud-logging
# google-cloud-storage
google-cloud-appengine-logging==1.8.0
# via google-cloud-logging
Expand All @@ -122,11 +124,11 @@ google-cloud-core==2.6.0
# -r requirements.in
# google-cloud-logging
# google-cloud-storage
google-cloud-error-reporting==1.4.0
google-cloud-error-reporting==1.16.0
# via -r requirements.in
google-cloud-kms==2.24.2
# via -r requirements.in
google-cloud-logging==2.7.1
google-cloud-logging==3.16.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Major bump sitting on the live error path, untested by CI. Because the middleware passes _use_grpc=False, reports go through _ErrorReportingLoggingAPI, which builds a google.cloud.logging.Client(...) and calls logger("errors").log_struct(...).

Mitigating: nothing in contentcuration/ imports google.cloud.logging directly; error-reporting 1.16.0 declares google-cloud-logging>=3.9.0, so upstream tests the pairing; 3.0.0's breaking changes are in the handler classes (AppEngineHandler/ContainerEngineHandler, setup_logging) and json-payload/resource-inference behavior — not the Client(...) + log_struct surface used here.

One behavior change to know about: 3.0.0 infers a default monitored resource per logger instead of defaulting to global, so the resource label on Error Reporting entries changes in production.

CI covers none of this — the middleware is only installed when GCLOUD_ERROR_REPORTING is set (contentcuration/settings.py:156) and no test imports it. Worth one manual report_exception() against a staging project before this reaches production.

# via google-cloud-error-reporting
google-cloud-storage==3.10.1
# via -r requirements.in
Expand All @@ -137,7 +139,7 @@ google-crc32c==1.8.0
# google-resumable-media
google-resumable-media==2.8.0
# via google-cloud-storage
googleapis-common-protos[grpc]==1.57.0
googleapis-common-protos==1.57.0
# via
# google-api-core
# google-cloud-audit-log
Expand All @@ -151,6 +153,8 @@ grpcio==1.78.0
# via
# google-api-core
# google-cloud-appengine-logging
# google-cloud-error-reporting
# google-cloud-logging
# googleapis-common-protos
# grpc-google-iam-v1
# grpcio-status
Expand Down Expand Up @@ -188,11 +192,12 @@ markdown-it-py==4.0.0
# via -r requirements.in
mdurl==0.1.2
# via markdown-it-py
opentelemetry-api==1.44.0
# via google-cloud-logging
packaging==26.2
# via
# -r requirements.in
# django-js-reverse
# google-cloud-error-reporting
# gunicorn
# kombu
pillow==12.3.0
Expand All @@ -213,7 +218,9 @@ protobuf==4.25.8
# google-api-core
# google-cloud-appengine-logging
# google-cloud-audit-log
# google-cloud-error-reporting
# google-cloud-kms
# google-cloud-logging
# googleapis-common-protos
# grpcio-status
# proto-plus
Expand Down Expand Up @@ -284,6 +291,7 @@ typing-extensions==4.15.0
# cryptography
# exceptiongroup
# grpcio
# opentelemetry-api
# pydantic
# pydantic-core
# referencing
Expand Down
Loading