feat: lake: read persisted code quality entries in lake lint --code-quality - #14933
Merged
wkrozowski merged 1 commit intoAug 27, 2026
Merged
Conversation
lake lint --code-qualitylake lint --code-quality
wkrozowski
force-pushed
the
wkr/code_quality_read_refactor
branch
from
August 26, 2026 14:10
395bfb9 to
a6dbd03
Compare
Contributor
Author
|
!bench |
|
Benchmark results for a6dbd03 against 31aea96 are in. There are significant results. @wkrozowski
Large changes (3✅)
Small changes (551✅, 4🟥)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes
lake lint --code-qualityemit the code quality entries that linters record during elaboration. Entries logged viaLean.Linter.logCodeQualityEntryIfare attributed to the producing linter's option name and are filtered by--lint-only; entries logged viaLean.Linter.logCodeQualityEntrycarry no attribution and are always emitted, so no linter selection flag can suppress them. Disabling a recording linter (e.g.--linters=-linter.foo) suppresses its attributed entries at elaboration time, and a module shared between several lint targets contributes its entries only once.Builds on #14914, which persists code quality entries in the
codeQualityLogExtenvironment extension. The extension now storesCodeQualityLogEntry, pairing each entry with the option name of the producing linter (nonefor entries logged unconditionally vialogCodeQualityEntry). On the Lake side,collectRecordedCodeQualityrecovers the per-module entries from the.oleans of each lint target's import closure and applies the--lint-onlyfilter to attributed entries. The now-deadMessageData.codeQualityEntry?and the unusedLean.Linter.CodeQuality.Basicimport inLean.Messageare removed.