docs: record that Mathlib now proves symplectic_matrix_det - #628
Open
ibrahimmian36 wants to merge 1 commit into
Open
ibrahimmian36 wants to merge 1 commit into
ibrahimmian36 wants to merge 1 commit into
Conversation
Mathlib PR #40352 (merged 2026-07-07) added `SymplecticGroup.det_eq_one`, which is exactly this problem's statement, and the toolchain bump of 2026-07-29 brought it into the pinned Mathlib. Since then the hole closes by `exact SymplecticGroup.det_eq_one _hA`. The manifest notes and source and the module docstring still described the identity as an open Mathlib TODO; say what happened and when. The formal statement is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mathlib PR #40352 (merged 2026-07-07) added
SymplecticGroup.det_eq_one, which is exactly this problem's statement, and the toolchain bump of 2026-07-29 brought it into the pinned Mathlib. Since thensymplectic_matrix_detcloses withexact SymplecticGroup.det_eq_one _hA; the two accepted post-bump solutions with public source are that line. The manifest notes and source and the module docstring still described the identity as an open Mathlib TODO. This says what happened and when. The formal statement is unchanged, and the problem is archived, so v1 standings are unaffected.Docstring-class edit in the shape of #501 and #502. The wording is offered as a draft; rewrite freely.
Validated with:
lake exe lean-eval check-problem-build --module LeanEval.LinearAlgebra.SymplecticDetlake exe lean-eval validate-manifest --structure-onlypython scripts/validate_catalog.py