ci: build mathlib's cache executable - #87
Merged
Merged
Conversation
Mathlib's own CI compiles the `cache` tool (`lake build cache check-yaml graph`) before the main build, so a Lean or Lake change that breaks `Cache/*.lean` turns Mathlib's nightly-testing branch red at once. lean4#15142 did exactly that today: `Lake.PackageEntrySrc.path` gained a `copy` flag and `Cache/Requests.lean:988` fails with `Missing cases: (Lake.PackageEntrySrc.path _ true)`. Downstream only built `Mathlib`, `Archive`, `Counterexamples` and `Wanted`, none of which import `Cache`, so it never noticed and no adaptation branch exists for it. Add `cache` to mathlib4's `build_targets` so the executable is compiled with the same `--wfail` as the rest. It depends only on core Lean and Lake, adds 41 jobs and links in a few seconds. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016T7xJY6pLYrh99DNzwj7oo
Kha
marked this pull request as ready for review
September 20, 2026 09:58
Contributor
Build report for ci: build mathlib's
|
| Repo | Critical | Build | Test | Lint |
|---|---|---|---|---|
| cslib | 🟥 in 6s | ⏭️ | ⏭️ |
Stayed green
| Repo | Critical | Build | Test | Lint |
|---|---|---|---|---|
| aesop | ✅ | ✅ in 7s | ✅ in 4s | ⏭️ |
| batteries | ✅ | ✅ in 4s | ✅ in 4s | ✅ in 2s |
| import-graph | ✅ | ✅ in 2s | ✅ in 4s | ⏭️ |
| lean4-cli | ✅ | ✅ in 1s | ✅ in 0s | ⏭️ |
| mathlib4 | ✅ | ✅ in 187s | ✅ in 329s | ✅ in 97s |
| plausible | ✅ | ✅ in 2s | ✅ in 2s | ⏭️ |
| ProofWidgets4 | ✅ | ✅ in 3s | ✅ in 1s | ⏭️ |
| quote4 | ✅ | ✅ in 2s | ✅ in 1s | ⏭️ |
| reference-manual | ✅ | ✅ in 15s | ⏭️ | ⏭️ |
| BibtexQuery | ✅ in 1s | ⏭️ | ⏭️ | |
| comparator | ✅ in 2s | ⏭️ | ⏭️ | |
| doc-gen4 | ✅ in 3s | ⏭️ | ⏭️ | |
| illuminate | ✅ in 4s | ✅ in 11s | ⏭️ | |
| lean4-unicode-basic | ✅ in 2s | ⏭️ | ⏭️ | |
| lean4export | ✅ in 0s | ✅ in 8s | ⏭️ | |
| LeanSearchClient | ✅ in 1s | ✅ in 0s | ⏭️ | |
| leansqlite | ✅ in 4s | ✅ in 19s | ⏭️ | |
| nerodia | ✅ in 3s | ✅ in 21s | ⏭️ | |
| repl | ✅ in 1s | ✅ in 56s | ⏭️ | |
| verso | ✅ in 36s | ✅ in 171s | ⏭️ | |
| verso-slides | ✅ in 7s | ✅ in 9s | ⏭️ | |
| verso-web-components | ✅ in 2s | ⏭️ | ⏭️ |
Garmelon
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mathlib's own CI compiles the
cachetool before the main build (lake build cache check-yaml graphin its setup step), so a Lean or Lake change that breaksCache/*.leanturns Mathlib's nightly-testing branch red immediately.🤖 Generated with Claude Code