Conversation
The merge with mathlib master brought in [mathlib4#42705](leanprover-community/mathlib4#42705), which makes the element type of `LE.ofMembership`/`Preorder.ofMembership`/ `PartialOrder.ofSetLike` implicit. The `PartialOrder (Fact P)` instance in `Cslib/Logics/LinearLogic/CLL/PhaseSemantics/Basic.lean` still passed `P` explicitly, so it failed to elaborate; every use of `≤` on `Fact P` in the rest of the file then lost its defeq to set inclusion, which is where the other 11 errors came from.
Contributor
Build report for fix: cslib breakage from the mathlib mergeTurned green:
Stayed green
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run 35484035829 on
nightly-2026-09-17failed incslibonly.cslibis noncritical, so the build report and GitHub both call the run successful, but the repo is red and is fixed here like any other break.cslib
Root cause. The
downstream: update repo mathlib4merge at the head of that run brought in mathlib4#42705, which makes the element type ofLE.ofMembership,Preorder.ofMembershipandPartialOrder.ofSetLikeimplicit:Cslib/Logics/LinearLogic/CLL/PhaseSemantics/Basic.leanstill wrotePartialOrder.ofSetLike (Fact P) P, which now elaborates as an over-applied term (Function expected at PartialOrder.ofSetLike (Fact P)). With thePartialOrder (Fact P)instance broken,≤onFact Plost its definitional unfolding to set inclusion, so the remaining 11 errors in the file —Set.mul_subset_mulapplied toG ≤ K, theIsConcreteLE (Fact P) Psynthesis failures, thePhaseSpace Propfailures — were all downstream of that one line.Fix. Drop the now-implicit argument:
That is the only occurrence of
ofSetLike/ofMembershipincslib.Verified locally on
nightly-2026-09-17, with--wfail --iofailasrepos.tomlconfigures:lake build(3244 jobs),lake testandlake lint(batteries/runLinter) all pass. CI had stoppedcslibat the build, so itstestandlintphases had not run this round; both are green here.Nothing was left unfinished:
cslibwas the only repo not green in that run, no repo was skipped behind it, and the whole red set is covered.