[#15215] fix: use pi_congr instead of forall_congr, deprecate the latter - #85
Open
downstream-lean4[bot] wants to merge 3 commits into
Open
downstream-lean4[bot] wants to merge 3 commits into
downstream-lean4[bot] wants to merge 3 commits into
Conversation
simp now rewrites under non-Prop foralls, which changes the elaboration of unitsSMulWithCancel; discharge the vacuous ofGroup case in unitsSMul_cancels_iff via its absurd hypothesis instead. Replace uses of the deprecated forall_congr by pi_congr, or by forall_congr' where an Iff is wanted.
simp-generated congruence proofs now use pi_congr in place of forall_congr.
Contributor
Author
Build report for downstream: follow upstream PRStayed green
|
Contributor
|
!bench mathlib4 |
|
Benchmark results for f121e0b against b9ce333 are in. There are significant results. @sgraf812
Small changes (1✅, 42🟥)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the adaptation PR for leanprover/lean4#15215.