chore(PFunctor): drop simp tags from non-universe generic bind lemma - #893
Open
dtumad wants to merge 2 commits into
Open
chore(PFunctor): drop simp tags from non-universe generic bind lemma#893dtumad wants to merge 2 commits into
dtumad wants to merge 2 commits into
Conversation
dtumad
requested review from
arademaker,
chenson2018,
fmontesi,
kim-em and
sorrachai
as code owners
September 10, 2026 22:39
Collaborator
|
This effectively reverts #417. We have to choose between:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
PFunctor.FreeM.bind mx myis marked tosimptomx >>= my, but the notationalBind.bindonly applies in cases where the return types of both monadic computation has the same universe level. This means othersimplemmas need to be written in both forms in order to provide full coverage.This PR drops this tag, and a similar tag on
FreeM.pure. It does not create asimppathway in the other direction, but that could be worth considering I think.