pole-instrument Technical Design - #8
Closed
chuntaojun wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Architecture Decision Record (ADR) documenting the proposed pole-instrument runtime/packaging boundary and introduces a regression-style unit test to ensure the design’s “public runtime contract” statements remain present over time.
Changes:
- Added
context-kg/technical/adr/pole-instrument.mddescribing the proposed launcher/runtime/adapter contract and safety constraints. - Added
packages/pole-client-python/tests/test_instrument_design.pyto assert the ADR continues to include specific contract-defining text (e.g., launcher grammar, exec semantics, fail-open behavior, and data-safety constraints).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/pole-client-python/tests/test_instrument_design.py | Adds a unittest that “pins” required design-contract phrases in the ADR to prevent accidental contract drift. |
| context-kg/technical/adr/pole-instrument.md | Introduces the proposed technical design/ADR for pole-instrument, including packaging boundary and launcher/runtime behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated delivery created by Dalqen.
Task:
task-3eac1f25dcef522a