Skip to content

fix(tests): remove unnecessary Thread.sleep from EventCorrelatorTest - #4927

Open
flrnd wants to merge 1 commit into
kubernetes-client:masterfrom
flrnd:fix-remove-thread-sleep-from-event-correlator-test
Open

flrnd wants to merge 1 commit into
kubernetes-client:masterfrom
flrnd:fix-remove-thread-sleep-from-event-correlator-test

Conversation

@flrnd

@flrnd flrnd commented Sep 29, 2026

Copy link
Copy Markdown

Notes

Remove the 100ms Thread.sleep from EventCorrelatorTest.

This test does not appear to involve asynchronous or threaded operations, so there is no synchronization primitive to replace the sleep with in this case.

The original test implementation used Joda DateTime and relied on the delay to ensure distinct timestamps.

The implementation now uses OffsetDateTime, which provides finer timestamp precision, remaining distinct without the artificial delay.

Verification

The test was run locally 100 times with Thread.sleep(100) removed. Consecutive OffsetDateTime.now() calls remained distinct, with observed differences below 1 ms, and EventCorrelatorTest continued to pass.

Remove the 100ms Thread.sleep from EventCorrelatorTest.

This test does not appear to involve asynchronous or threaded
operations, so there is no synchronization primitive to replace the
sleep with in this case.

The original test implementation used Joda DateTime and relied on the
delay to ensure distinct timestamps.

The implementation now uses OffsetDateTime, which provides finer
timestamp precision, remaining distinct without the artificial delay.
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flrnd
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

linux-foundation-easycla Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: flrnd / name: flrnd (fd34a69)

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @flrnd!

It looks like this is your first PR to kubernetes-client/java 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/java has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant