Skip to content

🌱 Plan rung: viewer wording, and the model without its routing envelope - #244

Open
ibolton336 wants to merge 1 commit into
konveyor:mainfrom
ibolton336:claude/plan-rung-wording
Open

ibolton336 wants to merge 1 commit into
konveyor:mainfrom
ibolton336:claude/plan-rung-wording

Conversation

@ibolton336

@ibolton336 ibolton336 commented Sep 17, 2026

Copy link
Copy Markdown
Member

What a viewer reads today

Watching a coolstore run on the ROKS demo cluster, the middle rung of the
plan ladder says:

Agent works its standing prompt (us.anthropic.claude-sonnet-4-5-20250929-v1:0, turn 17 of 200)

Two problems, both only in the text:

  • "standing prompt" is our word, not the viewer's — and it collides with
    the run's own prompt, which is the thing they might expect to be quoted.
    That branch has nothing to quote: the run was given no task text, and the
    agent prompt opens with a persona ("You are a senior Java engineer…") that
    says nothing about the work when cut to a line. So the rung now says what is
    true and nothing more — Agent is working — and the stage, model and
    turn budget beside it carry the rest. (The quoted-task branch,
    Agent works the task: "…", is unchanged.)
  • The model id is a routing envelope. us. is the cross-region inference
    profile's geo group, anthropic. the vendor namespace, -v1:0 the API
    version — none of it says which model is answering, and the rung is the only
    place a viewer sees the model while a run is going (the console shows it at
    Gateway-selection time, not on the run page).

After

Agent is working (claude-sonnet-4-5-20250929, turn 17 of 200)

and on a workflow stage:

Stage 2 of 3 — agent is working (claude-sonnet-4-5-20250929, turn 17 of 200)

modelDisplayName keeps the model's identity — the name and the snapshot
date
— and drops only the envelope. It is deliberately narrow:

in out
us.anthropic.claude-sonnet-4-5-20250929-v1:0 claude-sonnet-4-5-20250929
anthropic.claude-3-5-sonnet-20241022-v2:0 claude-3-5-sonnet-20241022
gemini-2.5-pro, gpt-4.1 unchanged — a version in the name is not a vendor namespace (the segment must be all letters to come off)
ai21.jamba-1-5-large-v1:0 ai21.jamba-1-5-large — digits in the segment, so the namespace stays
publishers/anthropic/models/… (Vertex) unchanged — path-shaped refs are left alone

Tradeoff worth a reviewer's eye: the geo prefix is information, and two
profiles that differ only by geo now render identically. I dropped it because
the run already pins one Gateway, whose spec.model.name and endpoint carry
the full id, as does the pod's KONVEYOR_LLM_MODEL. Say the word and I'll keep
it.

On the wording

CONTEXT.md does define Agent.spec.prompt as "standing instructions for
how the agent operates", so "standing instructions" was the other candidate and
would have kept a distinction: this run was given a task vs it is working
from the Agent's own instructions
. We took the plainer one — a viewer watching
a run cannot act on that distinction, and the ladder's job is to say where the
run is, not to name our domain objects.

No changelog fragment

The plan ladder itself (#230, merged 2026-09-15) is not in v0.11.0-alpha.4
(cut 2026-09-11) — planTaskRung does not exist in that tag. This wording has
therefore never been in a release, so there is nothing to tell users they need
to un-learn; 230-harness-plan-rung.yaml still describes the shipped behaviour
accurately.

Verification

  • cd harness && go test ./... — pass; TestPlanTaskRung gains a
    cross-region-Bedrock case (the exact ROKS string above), new
    TestModelDisplayName covers the table above plus "" and a bare "us."
  • go vet ./..., make lint — clean
  • Not seen in a console against a live run: the ROKS cluster runs the published
    image, not this branch.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 515e74af-34c3-4503-8011-4099b7b61b4d


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Two things a viewer reads on the middle rung, from watching a coolstore run
on the ROKS demo cluster:

  Agent works its standing prompt (us.anthropic.claude-sonnet-4-5-20250929-v1:0, turn 17 of 200)

"standing prompt" is our word, not theirs, and it collides with the run's
own prompt. There is nothing to quote in that branch — the run was given no
task text, and the agent prompt opens with a persona — so the rung now just
says what is true: "Agent is working". The stage, model and turn budget
beside it carry the rest.

The model is a Bedrock cross-region inference profile id: the geo group,
the vendor namespace and the "-v1:0" API version say nothing about which
model is answering. modelDisplayName drops those three and keeps identity —
name and snapshot date — so the rung reads "claude-sonnet-4-5-20250929".
It only touches that dotted shape: a vendor segment comes off only when it
is all letters, so "gemini-2.5-pro" and "gpt-4.1" keep their versions, and
a path-shaped Vertex ref is left alone. The full id is still on the Gateway
the run named and in the pod's KONVEYOR_LLM_MODEL.

No changelog fragment: the plan ladder (konveyor#230) is not in alpha.4, so this
wording has never been in a release.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: ibolton336 <ibolton@redhat.com>
@ibolton336
ibolton336 force-pushed the claude/plan-rung-wording branch from 3f96f3a to 1192754 Compare September 18, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant