Add TenantInfo to GenericResourceSpec - #674
Merged
Merged
Conversation
The billed org is discovered per tenant shape - a namespace annotation for client orgs, the cluster identity for managed orgs - but the identity itself should not depend on that. NamespaceInfo.AceOrgID/AceOrgMetadata are kept one release; TenantOrgID/TenantOrgMetadata hold the fallback for consumers. Signed-off-by: Arnob Kumar Saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the org-based licensing model.
Tenant identity is read off the namespace today, so it exists only for client orgs — a managed org owns whole clusters and goes unidentified. This moves the billed identity onto the event itself.
TenantInfo{OrgID, Metadata, Source}onGenericResourceSpec;Sourceisnamespace(client org) orcluster(managed org, from the cluster identity).NamespaceInfo.AceOrgID/AceOrgMetadatakeep working, marked deprecated for one release.TenantOrgID()/TenantOrgMetadata()hold the prefer-Tenant-fall-back-to-namespace rule in one place, so b3 and other consumers do not each reimplement it.Discovery differs per tenant shape; the billed identity should not.
Populated by
go.bytebuilders.dev/auditandkubedb.dev/provisioner.