Support Ubuntu 26.04 and every interim release - #41
Open
igorpecovnik wants to merge 1 commit into
Open
Conversation
Replace the hardcoded release substring lists with a numeric version comparison, so future Ubuntu releases work without another patch. rk-flash-tool/INSTALL and tone-dfu-tool/INSTALL stopped at 24 and hit "Ubuntu XX haven't been verified!" + exit 1 on anything newer. Since the top-level INSTALL runs the tools in sequence, that aborted the install after the Amlogic tool had already been set up. Behaviour on 12.04, 14.04, 16.04, 18.04, 18.10, 20.04, 22.04 and 24.04 is unchanged. Interim releases (15.10, 17.10, 19.04, 19.10, 21.04, 21.10, 23.04, 23.10, 25.04, 25.10) previously failed the check and now work too. Also pair libncurses5/6 with lib32ncurses5/6 in the same branch instead of hardcoding libncurses5 for every release. Signed-off-by: Igor Pecovnik <igor@armbian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR —
rk-flash-toolandtone-dfu-toolrefuse to install on Ubuntu 25.04+ with "Ubuntu XX haven't been verified!" andexit 1. Because the top-levelINSTALLruns the tools in sequence, that aborts the whole install right after the Amlogic tool has already been set up.The release checks are hardcoded substring lists (
=~ "20" || =~ "22" || =~ "24"), so they need a patch every six months — and they already missed every interim release. This swaps them for a numeric comparison:Nothing regresses. 12.04, 14.04, 16.04, 18.04, 18.10, 20.04, 22.04 and 24.04 all behave exactly as before — same udev rule picked, same ncurses5/6 split at 18.10, and 12.04/14.04 are still correctly refused by the Rockchip and Tone tools.
Newly working: 26.04, plus the interim releases the old lists forgot — 15.10, 17.10, 19.04, 19.10, 21.04, 21.10, 23.04, 23.10, 25.04, 25.10.
Also pairs
libncurses5/6withlib32ncurses5/6in the same branch, instead of hardcodinglibncurses5for every release.Verified:
bash -nclean on all five scripts; old vs new conditions evaluated side by side across 10.04 → 28.04; every package inhostdepsconfirmed present in 26.04 (resolute).Closes #38.