feat(mac): do not kill Keyman.app during config app startup 馃崕 - #16554
Draft
sgschantz wants to merge 1 commit into
Draft
feat(mac): do not kill Keyman.app during config app startup 馃崕#16554sgschantz wants to merge 1 commit into
sgschantz wants to merge 1 commit into
Conversation
at startup -- instead use notifications when app is running only force a restart of the input method if we need accessibility state during the setup flow Fixes: #16442
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
keymanapp-test-bot
Bot
changed the title
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of killing the Keyman input method to check accessibility at startup, use notifications if the
app is running.
Only force a restart of the input method if we need accessibility state during the setup flow
Fixes: #16442
Build-bot: release:mac
Test-bot: skip