Skip to content

fix(uxcore): make new-update modal dismissal stick #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaryWylde merged 1 commit into from
Aug 8, 2026
Merged

fix(uxcore): make new-update modal dismissal stick #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/uxcore/components/NewUpdateModal/NewUpdateModalContainer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ const NewUpdateModalContainer: FC = () => {
if (cancelled || !res || !res['Frontend modal visibility']) return;

// Dismissal is keyed to the CMS updatedAt: closing hides this update
// for the rest of the session, but a newly published one shows again.
if (sessionStorage.getItem(DISMISSED_KEY) === (res.updatedAt ?? 'seen'))
// until site data is cleared, but a newly published one shows again.
if (localStorage.getItem(DISMISSED_KEY) === (res.updatedAt ?? 'seen'))
return;

setData(res);
Expand All @@ -52,7 +52,7 @@ const NewUpdateModalContainer: FC = () => {
const handleClose = () => {
setOpen(false);
try {
sessionStorage.setItem(DISMISSED_KEY, data?.updatedAt ?? 'seen');
localStorage.setItem(DISMISSED_KEY, data?.updatedAt ?? 'seen');
} catch {
// Storage can be unavailable (private mode); closing still works.
}
Expand Down
Loading