refactor(bot): drop dead HTTP_methods module - #39
Merged
Merged
Conversation
None of get_my_ip/downloadFile/download_file is referenced anywhere in the repo — the module name doesn't appear outside the file itself. Downloads go through the aiogram bot session and the dialog engine now. It also held the only asyncio.CancelledError handler that swallowed cancellation into a False return, plus four print() calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
app/bot/utils/HTTP_methods.pyis unreachable: none ofget_my_ip,downloadFileordownload_fileis called anywhere, and the module namedoesn't appear outside the file itself. File downloads run through the aiogram
bot session and the dialog engine.
Worth noting what went with it —
download_filecaughtasyncio.CancelledErrorand turned it into a
Falsereturn, which would have quietly broken taskcancellation had anyone started using it.