fix(boosty): cancel hourly refresh task when publisher stops - #37
Merged
Merged
Conversation
The refresh task was created in run() and never cancelled, so it outlived the consumer loop and kept refreshing a session nobody used. Cancel it in a finally block and add lifecycle tests for both clean and failing exits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Boosty publisher starts an hourly token-refresh task in
run()and nevercancels it. When the consumer loop exits — cancelled from outside, or because
the consumer itself blew up — the task stays alive and keeps refreshing a
session nobody uses.
Cancel it in a
finallyblock, swallowing the expectedCancelledError.Tests cover both exits: a failing consumer loop and a clean return. Note for
reviewers: the tests patch
main.BasePublisher, notapp.shared.publishers.base— the publisher runs in-container with
shared...on the path, so those are twodistinct module objects and patching the wrong one silently does nothing.