Fixed 2 issues: obj deletion order and a gcc compiler warning. - #3
Open
animulay wants to merge 1 commit into
Open
Fixed 2 issues: obj deletion order and a gcc compiler warning.#3animulay wants to merge 1 commit into
animulay wants to merge 1 commit into
Conversation
1. // test_benchmark.cc
Fixed the deletion order.
2. // test_basic.cc
TimerEvent<Callback> timer([] () { });
Passing the lambda expression to TimerEvent<std::function<void()>>
forces the compiler to create an implicit temporary std::function.
Initializing callback_ from that temporary still invokes std::function's
copy constructor, triggering a known GCC 14 static-analysis bug
(-Wmaybe-uninitialized) during template inlining.
To fix, updated TimerEvent explicit constructor.
Author
|
Hi, I came across the ratas repo today. Thanks for posting the hierarchical timer wheel implementation. The README clearly mentions that it's "C++11 implementation". However, when I tried to build it locally on my dev setup (Ubuntu 24.04 with gcc 13.3.0), the generated makefiles kept using newer version of C++ (c++20). I have fixed 2 small issues here. This is my first PR on GitHub! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// test_benchmark.cc Fixed the deletion order.
// test_basic.cc TimerEvent timer([] () { });
Passing the lambda expression to TimerEvent<std::function<void()>> forces the compiler to create an implicit temporary std::function.
Initializing callback_ from that temporary still invokes std::function's copy constructor, triggering a known GCC 14 static-analysis bug (-Wmaybe-uninitialized) during template inlining.
To fix, updated TimerEvent explicit constructor.