fix: make /health endpoint trailing-slash tolerant - #70
Merged
Conversation
The health route and its auth bypass both matched the exact literal path /health, so /health/ fell through to the auth check (401) and would 404 even with a valid token. Both patterns now accept an optional trailing slash. Fixes #67 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q25veeccRvgA5zjp6Fhijq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #67
Both the health-route registration and the auth-bypass pattern matched the exact literal
/health, so/health/fell through to the auth check (401, since noAuthorizationheader is expected on a public probe) and would 404 even with a valid token. Load balancers and k8s probes commonly append a trailing slash.Both patterns now use
/health{/}?so the trailing-slash variant is treated identically to/health.Verified: reproduced 401 on
GET /health/against the old code, wrote a regression test asserting 200 + no auth required, confirmed it failed before the fix and passes after. Full test suite (217 tests) green.🤖 Generated with Claude Code