[fork CI check] Only require jax to build where jaxlib has a wheel - #1
Closed
jdeast wants to merge 1 commit into
Closed
[fork CI check] Only require jax to build where jaxlib has a wheel#1jdeast wants to merge 1 commit into
jdeast wants to merge 1 commit into
Conversation
The JAX extension is already optional in CMakeLists: it probes for jax.ffi.include_dir() and, when that fails, prints 'Skipping JAX extension' and builds everything else. But pip resolves [build-system] requires in an isolated environment before CMake runs, so that graceful path is unreachable and the pinned jax==0.8.0 makes the extension mandatory in practice. Where jaxlib publishes no wheel this makes the sdist unbuildable. macOS x86_64 is the case that bites: jaxlib's last wheel there is 0.4.38 and jaxlib ships no sdist, so the build fails while installing build dependencies, before any C++ is compiled. Adding an environment marker keeps jax present everywhere wheels are built (the cibuildwheel matrix is linux x86_64, macOS arm64 and win_amd64, all of which have jaxlib wheels), so released wheels are unaffected and still contain the extension. Simply dropping jax from requires would instead have let CMake silently skip the extension during release builds, which is why this uses a marker rather than a removal.
Owner
Author
|
Superseded by exoplanet-dev#193 (this branch, opened upstream). Fork CI history retained here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal PR to exercise CI before opening upstream. Do not merge.