Move swiftDemangle linkage to ComputeCxx - #71
Merged
jcmosc merged 1 commit intoSep 13, 2026
Conversation
Kyle-Ye
force-pushed
the
codex/compute-linux-demangle
branch
from
September 6, 2026 17:11
60f82c8 to
3180e56
Compare
Owner
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream packages can fail to link/test on Linux/macOS because
ComputeCxxreferences Swift demangler symbols, but only the test targets linkswiftDemangle.Move the unconditional
swiftDemanglelinker setting toComputeCxxand remove the declarations from the three test targets. Tests and downstream consumers inherit the dependency from the library target that uses it.Validated with Swift 6.3.3 on ARM64: